Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to unassign Valuator role #2110

Merged
merged 3 commits into from
Nov 21, 2017
Merged

Add option to unassign Valuator role #2110

merged 3 commits into from
Nov 21, 2017

Conversation

aitbw
Copy link
Collaborator

@aitbw aitbw commented Oct 26, 2017

Where

What

  • Add the option for administrators to unassign Valuators

How

  • Added 'Delete' button to Valuators index and search views
  • Added English and Spanish locales
  • Added destroy route for Valuators, destroy action in Admin::ValuatorsController and appended the destroy ability in the abilities/administrator model

Test

  • Increased coverage for the Destroy Valuator scenario

@zamuro zamuro force-pushed the aperez-remove-valuator-role branch from 4030ac9 to 9c8e9da Compare October 27, 2017 15:06
@zamuro zamuro force-pushed the aperez-remove-valuator-role branch from 9c8e9da to 51dfab2 Compare November 6, 2017 16:25
bertocq
bertocq approved these changes Nov 21, 2017
View reviewed changes
Copy link
Collaborator

@bertocq bertocq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice!

@bertocq bertocq merged commit 104a26d into consuldemocracy:master Nov 21, 2017
This was referenced Nov 21, 2017
Merged
Closed
Merged
@aitbw aitbw deleted the aperez-remove-valuator-role branch January 15, 2018 18:38
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
@bertocq
Merge pull request consuldemocracy#2110 from wairbut-m2c/aperez-remov…
e3ebee7 
…e-valuator-role

Add option to unassign Valuator role
Senen pushed a commit to rockandror/consuldemocracy that referenced this pull request May 31, 2021
@ajmorenoh
Merge pull request consuldemocracy#2110 from AyuntamientoMadrid/master
a2ddb79 
Cambios con nuevo módulo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertocq bertocq bertocq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aitbw @bertocq