Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design improvements #2170

Merged
merged 12 commits into from
Dec 14, 2017
Merged

Design improvements #2170

merged 12 commits into from
Dec 14, 2017

Conversation

decabeza
Copy link
Collaborator

@decabeza decabeza commented Dec 11, 2017 •
edited by bertocq

What

  • Some minor improvements of design.

How

  • Adds margin to maps on proposal and budget investment show views.
  • Changes title text for public interests list.
  • Adds setting Setting['feature.allow_images'] to allow images for proposals and budget investment projects.
  • Improves layout for proposals and budget investment with images on index view.
  • Improves styles and texts for Follow button.
  • Improves following page on my activity, shows public interest (tags) only in this view.
  • Removes some unused i18n keys.

Screenshots

Margin on maps

margin_map

Index with images

proposals_images

Follow button

follow_button

Mi activity/follow (before)

follow_before

Mi activity/follow (after)

follow_after

Test

Increased

Warnings

  • The Setting['feature.allow_images'] allow upload and show images for both (proposals and budget investment projects).

bertocq
bertocq approved these changes Dec 13, 2017
View reviewed changes
Copy link
Collaborator

@bertocq bertocq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@bertocq bertocq changed the title [WIP] Design improvements Design improvements Dec 13, 2017
@decabeza decabeza merged commit 19925de into master Dec 14, 2017
@decabeza decabeza deleted the design branch December 14, 2017 10:31
@decabeza
Copy link
Collaborator Author

💃

@voodoorai2000 voodoorai2000 mentioned this pull request Dec 14, 2017
Merged
@bertocq bertocq added this to the v0.12 milestone Dec 14, 2017
@decabeza decabeza mentioned this pull request Dec 14, 2017
Merged
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
@decabeza
Merge pull request consuldemocracy#2170 from consul/design
4be98c2 
Design improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertocq bertocq bertocq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@decabeza @bertocq