Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications for hidden resources #2172

Merged
merged 4 commits into from
Dec 12, 2017
Merged

Notifications for hidden resources #2172

merged 4 commits into from
Dec 12, 2017

Conversation

voodoorai2000
Copy link
Member

Where

What

  • Displays an appropriate message when a notification belongs to a resource that has been hidden

How

  • Checking for the presence of the related resource in the view and displaying this message it if has been hidden.

Screenshots

notifications

Deployment

  • As usual

Warnings

  • None

bertocq
bertocq approved these changes Dec 12, 2017
View reviewed changes
Copy link
Collaborator

@bertocq bertocq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@voodoorai2000 voodoorai2000 merged commit d49a1dc into master Dec 12, 2017
@voodoorai2000 voodoorai2000 deleted the notifications branch December 12, 2017 15:26
@voodoorai2000 voodoorai2000 mentioned this pull request Dec 12, 2017
Merged
@bertocq bertocq mentioned this pull request Dec 14, 2017
Closed
@voodoorai2000 voodoorai2000 mentioned this pull request Dec 14, 2017
Merged
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
@voodoorai2000
Merge pull request consuldemocracy#2172 from consul/notifications
d1a792a 
Notifications for hidden resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertocq bertocq bertocq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@voodoorai2000 @bertocq