Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documents to milestones #2191

Conversation

iagirre
Copy link

@iagirre iagirre commented Dec 14, 2017

Where

What

Add documents to milestones, so that admins can add them when creating milestones and users can see them when viewing milestones.

How

  • Make the Budget::Investment::Milestone documentable.
  • Add a document uploader field to the milestones form that lets admins upload up to 3 docs, pdf format.
  • Add a column to milestones list with a link to each document, if there are. If there aren't, the table column is empty.
  • The milestones' documents are accessible in the public investment view.

Screenshots

Milestone with image and document

milestones01

Milestone only with a document

milestones02

Admin views

milestones03
milestones04

Test

  • Feature specs to test the admin forms.
  • Feature specs to test if the documents are accessible for the user.

Deployment

Nothing.

Warnings

The documents bug of this issue #2171 also happens.

iagirre added 2 commits December 14, 2017 10:53
Add fields to the milestone form so that the admin can attach 0, 1 or multiple documents.
Add column to milestone list with a link to documents (if there is any).
Make documents accessible from the milestone view for users.
@decabeza decabeza merged commit 09b5447 into consuldemocracy:master Dec 14, 2017
@iagirre iagirre deleted the iagirre-add-documents-to-milestones branch January 16, 2018 07:15
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
…documents-to-milestones

Add documents to milestones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants