Make Milestones description required, hide title usage #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decabeza
approved these changes
Dec 15, 2017
bertocq
force-pushed
the
milestones_improvements
branch
from
2145be1
to
7f41242
Compare
bertocq
force-pushed
the
milestones_improvements
branch
from
7f41242
to
91e14f2
Compare
clairezed
pushed a commit
to CDJ11/CDJ
that referenced
this pull request
Jun 26, 2018
…ements Make Milestones description required, hide title usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
Milestone's seem to need a description but not always a title.
How
Screenshots
Admin's Milestone form with title input hidden:
Admin's Milestone list with default value for titles
Test
Increased to cover description presence validation and fixed to cover title hiding
Deployment
As usual, check warnings section
Warnings
The presence validation of milestone's description shouldn't affect existing milestones for showing but it will for editing (requiring a description to complete the form submission). A rake task to fill with an empty description text doesn't seem like a great option. I think it's on each fork situation to decide what's best: fill with default value, remove the presence validation, or if there are existing milestones that won't be edited ... just do nothing.