Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow destroying budgets without investments #2283

Merged
merged 5 commits into from Jan 9, 2018

Conversation

bertocq
Copy link
Collaborator

@bertocq bertocq commented Jan 8, 2018

Where

What

Allowing admins to destroy budgets that have no associated investments from the Edit form.

How

  • Adding a destroy button consistent with others in the admin sections
  • Checking the Budget has no associated investments before destroy, showing an error notice explaining the reason behind if so.

Screenshots

When the Budget has no investments

budget_destroy_success

When the Budget does have investments

budget_destroy_unable

Test

Extended existent admin budget feature spec adding a "Destroy" scenario that checks both a budget without investments and budget with investments destroyal.

Deployment

As usual

Warnings

None

Copy link
Contributor

@MariaCheca MariaCheca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice gifs, by the way 🕶

@bertocq bertocq force-pushed the feature/2275#destroy_budgets branch from c944be1 to b1d685c Compare January 8, 2018 17:21
@bertocq
Copy link
Collaborator Author

bertocq commented Jan 8, 2018

@MariaCheca all thanks to @justinfrankel 's LiceCap my kudos 👏

@bertocq bertocq merged commit 5f1d222 into master Jan 9, 2018
@bertocq bertocq deleted the feature/2275#destroy_budgets branch January 9, 2018 10:04
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
…roy_budgets

Allow destroying budgets without investments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow admins to delete Budgets
3 participants