Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Budget::Phases backend #2323

Merged
merged 17 commits into from
Jan 16, 2018
Merged

Create Budget::Phases backend #2323

merged 17 commits into from
Jan 16, 2018

Commits on Jan 16, 2018

  1. Correctly indent private function at budget model

    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    5016568 View commit details
    Browse the repository at this point in the history

  2. Create description_for_phase helper method at Budget, to make it easi… 

    …er to get non-active-phase description
    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    153b46b View commit details
    Browse the repository at this point in the history

  3. Create Budget Phase table at database

    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    82d6725 View commit details
    Browse the repository at this point in the history

  4. Add Budget::Phase model, spec and factory 

    Create a new Budget::Phase model that:
* Stablishes a relation with its budget
* Stablishes relation with two other Budget::Phases (previous and next)
* Validates basic dates range, kind and description rules.
* Adds scopes to get the ones enabled as well as each individual phase

Create a factory that generates a basic and valid Budget::Phase

Create a model spec that checks kind, date range and budget validations.
    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    36e74d0 View commit details
    Browse the repository at this point in the history

  5. Refactor budget's phase max description lenght from Budget to Phase m… 

    …odel
    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    f2228a9 View commit details
    Browse the repository at this point in the history

  6. Refactor Budget::PHASES constant to Budget::Phase::PHASE_KINDS

    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    66691b6 View commit details
    Browse the repository at this point in the history

  7. Refactor Budget publishing prices phases constant to Budget::Phase model

    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    ca3d759 View commit details
    Browse the repository at this point in the history

  8. Add phases relation at Budget model, as well as current_phase helper … 

    …method
    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    10f5cc0 View commit details
    Browse the repository at this point in the history

  9. Create all Phases after a Budget creation

    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    59fb0b5 View commit details
    Browse the repository at this point in the history

  10. Add next/prev enabled phase helper functions to Budget::Phase with mo… 

    …del specs
    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    21b6210 View commit details
    Browse the repository at this point in the history

  11. Add description sanitization to Budget::Phase with model specs

    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    d505cda View commit details
    Browse the repository at this point in the history

  12. Validate next/prev phases before saving a Budget::Phase, with model s… 

    …pecs
    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    601351d View commit details
    Browse the repository at this point in the history

  13. Adjust date ranges of prev/next phases when enabling/disabling a Budg… 

    …et::Phase, with model specs
    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    313d8d2 View commit details
    Browse the repository at this point in the history

  14. Add a rake task to generate missing Budget::Phase's and migrate descr… 

    …icptions
    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    02d596c View commit details
    Browse the repository at this point in the history

  15. Update changelog add and deprecated sections for unreleased block

    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    005d08e View commit details
    Browse the repository at this point in the history

  16. Merge branch 'master' into feature/budget_phases

    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    d44db9c View commit details
    Browse the repository at this point in the history

  17. Fix conflicts with merged branch, Budget::PHASES have moved, and desc… 

    …ribed_class usage is a must
    @bertocq
    bertocq committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    8b469c5 View commit details
    Browse the repository at this point in the history