Improvements for Admin::Budget::Investment filters #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitbw
force-pushed
the
aperez-investments-filters
branch
4 times, most recently
from
4333b79
to
0a80a66
Compare
aitbw
changed the title
aitbw
force-pushed
the
aperez-investments-filters
branch
2 times, most recently
from
dca61ea
to
4646270
Compare
MariaCheca
reviewed
Jan 22, 2018
There was a problem hiding this comment.
Looks good! Otherwise, as these changes concern files related to the frontend I'm missing some screen shots of the result to have more context, could you add them to the PR @aitbw? Thanks a lot! 🤗
| @@ -15,6 +15,7 @@ class Admin::BudgetInvestmentsController < Admin::BaseController | |||
| def index | |||
| respond_to do |format| | |||
| format.html | |||
| format.js { render layout: false } | |||
There was a problem hiding this comment.
So we can make use of the advanced filters without reloading the entire page and just update what's needed —see GIF above.
MariaCheca
approved these changes
Jan 22, 2018
aitbw
force-pushed
the
aperez-investments-filters
branch
from
4646270
to
3f6a918
Compare
This was referenced Jan 29, 2018
clairezed
pushed a commit
to CDJ11/CDJ
that referenced
this pull request
Jun 26, 2018
…tments-filters Improvements for Admin::Budget::Investment filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
Admin::Budget::Investmentindex view when the user wants to filter shown recordsHow
feasible,selected,undecided,unfeasibleandmax_supports_per_headingfilterswithout_valuatorandunder_valuationtabbed filterstbodyHTML tag ininvestmentspartialselectionheader oninvestmentspartial withselectedAdmin::Budget::Investmentfilter-related failing specs were adapted to fit the new UImax_supports_per_headingfilter (Taken from Ayuntamiento de Madrid)currently applied filtersmessage to the userScreenshots
Test
max_supports_per_headingfilter, fixed coverage as necessaryWarnings
These specs were commented for this PR since Improve investment's filters #1624 (as shown on the mockup and thePendingsection) are, well, pending. Awaiting further requirements to re-enable the#winnersfilter tabThefilters-usedcombination description is the only thing missing ATM