Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budget new "Information" phase #2349

Conversation

iagirre
Copy link

@iagirre iagirre commented Jan 19, 2018

Where

What

Add a new phase called "Information", between "Drafting" and "Accepting" phases. This new phase will not have any link, just the information about the money and the dates.

How

  • Add a new phase "informating" to PHASE_KINDS (it's called "informating", not "information", to follow the same structure of other phases).
  • Add a new scope for that phase to budget and phase models, and functions to check if the budget is in the phase or not.
  • If the budget is in informating phase, do not show the heading as links, but as simple text. The map and the heading list links below it have been removed for this phase.

Screenshots

information01

Test

  • Add trait :informating to budgets factory.
  • Add a new scenario to the budgets index context, where the index wihout links is tested.
  • budget and phase model specs have been modified to include the new "Information" phase.

Deployment

There is a migration (explanation in 'Warnings' section).

Warnings

I added a migration to add the column description_informating to budgets (even if it will be deprecated soon) because in this version of master they are being used when creating a new budget and when running dev_seed.

@iagirre iagirre force-pushed the iagirre-budgets-new-information-phase branch from ef95fc8 to fae70b6 Compare January 19, 2018 14:03
@raul-fuentes raul-fuentes force-pushed the iagirre-budgets-new-information-phase branch 5 times, most recently from 2db3758 to 5d71222 Compare January 22, 2018 17:03
@iagirre iagirre force-pushed the iagirre-budgets-new-information-phase branch 2 times, most recently from 16bfbbb to b99664c Compare January 23, 2018 10:18
@iagirre iagirre force-pushed the iagirre-budgets-new-information-phase branch from b99664c to 4bb872b Compare January 23, 2018 14:42
@MariaCheca MariaCheca merged commit 0dd71e6 into consuldemocracy:master Jan 23, 2018
@aitbw aitbw deleted the iagirre-budgets-new-information-phase branch February 21, 2018 15:40
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
…ets-new-information-phase

Budget new "Information" phase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Budget new "Information" phase
3 participants