Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve heading names at select boxes #2373

Merged
merged 4 commits into from Jan 31, 2018
Merged

Conversation

bertocq
Copy link
Collaborator

@bertocq bertocq commented Jan 24, 2018

Where

What

This is a Backport from madrid's fork, taking only the improvements that may also apply to consul:

  • Not showing the Group name along the Heading name when there's only one Heading for that Group (at the dropdown list)
  • Moving to Group model the logic to check if it has only one heading

How

Cherrypicking and editing relevant commits, check the original PR for more context.

Screenshots

screen shot 2018-01-22 at 19 49 47

Test

Updated to reflect new Heading options naming rules

Deployment

As usual

Warnings

None

Copy link
Member

@voodoorai2000 voodoorai2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

@bertocq bertocq merged commit f0f41b0 into master Jan 31, 2018
@bertocq bertocq deleted the single_heading_group_names branch January 31, 2018 01:35
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
…oup_names

Improve heading names at select boxes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants