Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only current budget tags in admin budget #2387

Conversation

vicentemendozam
Copy link
Contributor

Where

What

  • Show only the tags of the current budget in the admin budget page

How

  • In the tag's search modify the method to only find the tags of the current budget.

Screenshots

  • No changes have been added to the interface.

Test

  • Added a test with two different budgets and different tags. And verify that only the current budget tags are displayed.

Deployment

-N/A

@vicentemendozam vicentemendozam force-pushed the show_only_current_budget_tags_in_admin_budget branch from eee23d9 to 45a86d0 Compare January 26, 2018 10:31
@voodoorai2000
Copy link
Member

Awesome!

@vicentemendozam when in a controller or helper, try to avoid using where, instead create a scope or class method in the model 👌

@voodoorai2000 voodoorai2000 merged commit b5cb5e2 into consuldemocracy:master Jan 29, 2018
@aitbw aitbw deleted the show_only_current_budget_tags_in_admin_budget branch January 29, 2018 19:57
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
…rrent_budget_tags_in_admin_budget

Show only current budget tags in admin budget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants