Hide order selectors when only one order available #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertocq
changed the title
bertocq
force-pushed
the
hide_order_selector_if_only_one_order
branch
from
6bd55a2
to
e5ce55b
Compare
decabeza
approved these changes
Jan 30, 2018
clairezed
pushed a commit
to CDJ11/CDJ
that referenced
this pull request
Jun 26, 2018
…or_if_only_one_order Hide order selectors when only one order available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
On upcoming internal comments we'll offer only one ordering option (Oldest). But when there's only one option... what's the point of showing the selection box anymore? It'll trick the user into thinking there's more to choose from. I'd rather not see it :) (although I agree that @decabeza may
think best option here would be to show the current ordering method but in plain text... if that's the case fire your mockup guns 🤗 )
How
Simple if statement checking if valid orders are more than one
Screenshots
Before
After
Test
Instead of doing hacky things on specs to test this, it will be tested at the only place that has only one ordering option for comments: Valuator comments #2403
Deployment
As usual
Warnings
None but that mention at #What for possible UI/UX improvement