Use user locale instead of default locale to format currencies #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApplicationHelper#format_price and Budget#formatted_amount has the same objective and code, but the Budget#formatted_amount method also uses the currency of the Budget to correctly give currencies format. By replacing usage of format_price with formatted_amount we can remove format_price and have a single location for currency format logic.
bertocq
force-pushed
the
fix_currency_locale
branch
from
ada2240
to
6e84373
Compare
bertocq
changed the title
|
Checked at Madrid's fork 👌 production server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
All currencies are formatted using the default locale language (I18n.default_locale) instead of the user selected language. We need to use the user language to format currencies
How
Screenshots
Before
After
Notes
None