Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help text #2452

Merged
merged 2 commits into from
Feb 9, 2018
Merged

Help text #2452

merged 2 commits into from
Feb 9, 2018

Conversation

decabeza
Copy link
Collaborator

@decabeza decabeza commented Feb 7, 2018

What

  • Adds missing polls button on help page
  • Adds new legislation processes section on help page

Screenshots

screen shot 2018-02-07 at 19 11 28

screen shot 2018-02-07 at 19 11 33

</p>
<ul class="features">
<li>
<%= t("pages.help.processes.feature",
Copy link
Collaborator

@bertocq bertocq Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see wat you did there

An I really appreciated the effort to comply with the 100char line length policy :). But.. sometimes in order to achieve (to improve readability) we go in the opposite direction... making it harder to understand. What do you think about switching those for lines:

<%= t("pages.help.processes.feature",
      link: link_to(t("pages.help.processes.link"), legislation_processes_path),
      sign_up: link_to(t("pages.help.processes.sign_up", org: setting['org_name']),
                          new_user_registration_path)).html_safe %>

For this 4:

<% link = link_to(t("pages.help.processes.link"), legislation_processes_path) %>
<% sign_up_link = t("pages.help.processes.sign_up", org: setting['org_name']) %>
<% sign_up = link_to(sign_up_link, new_user_registration_path)).html_safe %>
<%= t("pages.help.processes.feature", link: link, sign_up: sign_up %>

Same amount of space, but easier to follow the substitutions and translations (in my opinion...). If you agree with me I'm pretty sure you'll see the same pattern at lines 8 & 9 :)

And again thank you so much for that line compliance, it really makes my day see the effort and concern about it :) 👏

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done! 😉 👍

@bertocq bertocq merged commit 2bcb9b3 into master Feb 9, 2018
@bertocq bertocq deleted the help-text branch February 9, 2018 11:09
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants