Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky spec: users without email should not receive emails #2453

Conversation

iagirre
Copy link

@iagirre iagirre commented Feb 8, 2018

Where

What

Hunt the flaky that appears in spec/features/emails_spec.rb:509.

How

Explained in the related PR.

Screenshots

There aren't

Test

Explained in the related PR

Deployment

Nothing to apply

Warnings

Nothing to apply

… described. JS has been avoided because it was one of the problems involved and it wasn't completely necessary.
Copy link
Collaborator

@bertocq bertocq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @iagirre

@bertocq bertocq merged commit 5ddcac8 into consuldemocracy:master Feb 8, 2018
@iagirre iagirre changed the title Backport PR #1206 from Madrid's fork Fix flaky spec: users without email should not receive emails Feb 9, 2018
@aitbw aitbw deleted the backport-1194-emails-users-wo-email-should-not-receive-emails branch February 9, 2018 14:23
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
…4-emails-users-wo-email-should-not-receive-emails

Backport PR consuldemocracy#1206 from Madrid's fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants