Fix flaky spec: random investments order scenario #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of appearing, also added test to cover edge cases (case in fact, the coincidence of the seeds it's correct) Conflicts: app/controllers/budgets/investments_controller.rb
raul-fuentes
changed the title
bertocq
approved these changes
Feb 9, 2018
bertocq
changed the title
aitbw
deleted the
backport_1191_flaky_budget_investments_orders_random
branch
raul-fuentes
restored the
backport_1191_flaky_budget_investments_orders_random
branch
clairezed
pushed a commit
to CDJ11/CDJ
that referenced
this pull request
Jun 26, 2018
…1_flaky_budget_investments_orders_random Fix flaky spec: random investments order scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
Fix rspec ./spec/features/budgets/investments_spec.rb:256
How
Explained in the related PR.
Screenshots
There aren't
Test
Explained in the related PR
Deployment
Nothing to apply
Warnings
Nothing to apply