Valuators cannot reopen finished valuations #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valuators shouldn't be able to valuate an investment which valuation has already been finished (only admins can)
Valuators should not be able to edit a finished valuation (only admins should). The valuation form is only shown to the valuator if he has that ability (we've previously modified app/models/abilities/valuator.rb to be able to rely on `valuate` over an investment to check that) If the valuator can't see the form, we present him just the data in plain text.
voodoorai2000
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This PR closes issue #2501
This PR is a production tested backport from Madrid's fork AyuntamientoMadrid#1337
Objectives
Valuators (that aren't admins) should not be able to reopen/edit an investment's finished valuation.
Visual Changes
How Admins see a finished valuation form
How non-admin Valuators see a finished valuation form
Notes
None