Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rake db:dev_seed task flaky spec #2522

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Fix rake db:dev_seed task flaky spec #2522

merged 1 commit into from
Mar 27, 2018

Conversation

aitbw
Copy link
Collaborator

@aitbw aitbw commented Mar 6, 2018

References

Objectives

  • Backport of the aforementioned PR into CONSUL to mitigate entirely this flaky spec, see original PR for full details

Visual Changes (if any)

  • None

Notes

  • Fixed coverage, so all green! ✅
  • This is a partial backport —that is, not all commits done on the original PR were cherry picked into this branch but rather the only one that was relevant

@aitbw aitbw mentioned this pull request Mar 9, 2018
Merged
voodoorai2000
voodoorai2000 approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@voodoorai2000 voodoorai2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@voodoorai2000 voodoorai2000 merged commit 0b4b896 into consuldemocracy:master Mar 27, 2018
@aitbw aitbw deleted the fix/dev_seed_flaky_spec_backport branch March 27, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voodoorai2000 voodoorai2000 voodoorai2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aitbw @voodoorai2000