Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes social share buttons #2525

Merged
merged 11 commits into from
Mar 8, 2018
Merged

Fixes social share buttons #2525

merged 11 commits into from
Mar 8, 2018

Conversation

decabeza
Copy link
Collaborator

@decabeza decabeza commented Mar 7, 2018 •
edited

References

This PR is a backport from Madrid's forks, including the following PR's:

Related Issues:

Objectives

  1. Fixes problem on Facebook share button adding a description. This adds the required data-desc element, and Facebook will then accept the request.

  2. Replaces hardcoded social share button tag with correct shared/social_share partial.

  3. Adds buttons to social share on legislation processes.

voodoorai2000
voodoorai2000 approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@voodoorai2000 voodoorai2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@decabeza decabeza merged commit 8c6c567 into master Mar 8, 2018
@decabeza decabeza deleted the social-share branch March 8, 2018 16:46
@javierm javierm mentioned this pull request Nov 13, 2019
Closed
@javierm javierm mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voodoorai2000 voodoorai2000 voodoorai2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adds social share buttons on legislation processes
2 participants
@decabeza @voodoorai2000