Allow supporting investments on more than one heading per group #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have the option of voting in multiple headings per group, the method of voting in a “different heading assigned” has become deprecated and thus removed
There was some inconsistency in this file, the `confirm_group` key was in both the custom translations file and the default translations file. Remove duplication and make it a default as it is a clearer message for users. If an installation want to edit this message they can still do it in the custom translations file
Temporarily… because there are 2 kinds of Ruby developers, those who indent methods under `private` and does who don’t https://gist.github.com/joefiorini/1049083#gistcomment-37692
This method was used only in Madrid’s fork, but it is now needed to complete the backport for voting in multiple headings There wasn’t a test in Madrid, so here goes one too. Even though, the responsibility should probably be moved soon to the `Budget::Heading`. For consistency with the related methods and tests it has been left in the investment_spec
voodoorai2000
force-pushed
the
vote_in_multiple_headings
branch
from
1a818ec
to
5c6eaa7
Compare
bertocq
approved these changes
Mar 22, 2018
The user was able to vote as many investments as wanted in the first heading voted. However in the second heading voted, only one investment could be voted This was due to the previous implementation, where you could only vote in one heading. Note the `first` call in method `heading_voted_by_user?(user)` This commits simplifies the logic and allows voting for any investment in any heading that the user has previously voted in
voodoorai2000
changed the title
voodoorai2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Issue: #2320
Backport: AyuntamientoMadrid#1382
Related: #2547
Objectives
Allow users to support in multiple headings of a single group by changing the maxium number of votable headings from the admin section
Visual Changes
Notes
Now that we have the option of voting in multiple headings per group, the method of voting in a
different heading assignedhas become deprecated and thus removed.Instead, knowing if a user can vote in a new heading, depends on the maximum votable headings per group variable.