Add Valuator Group name validation & related specs #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertocq
force-pushed
the
refactor_for_valuator_groups
branch
from
30ee22c
to
7ee9d67
Compare
Why: ValuatorGroup name should be unique and present to be able to identify correctly each of them. How: - Adding a presence & uniqueness validation at the model - Adding a sequenced value for name attribute at its factory - Adding missing model spec that covers validations
bertocq
force-pushed
the
refactor_for_valuator_groups
branch
from
7ee9d67
to
e38b4d3
Compare
voodoorai2000
approved these changes
Apr 5, 2018
Budget::Investment#by_valuator_group scope didn't had a test scenario
bertocq
force-pushed
the
refactor_for_valuator_groups
branch
from
e38b4d3
to
43d78c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is a backport of Madrid's fork merged & tested in production PR AyuntamientoMadrid#1358
Objectives
As a refactor for following PR's AyuntamientoMadrid#1357 & AyuntamientoMadrid#1359
Visual Changes (if any)
None
Notes
None