Foundation update #2590
Merged
Foundation update #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decabeza
force-pushed
the
foundation-update
branch
2 times, most recently
from
0395a7c
to
36d1ba5
Compare
decabeza
force-pushed
the
foundation-update
branch
from
290ff26
to
4df12b8
Compare
decabeza
force-pushed
the
foundation-update
branch
from
4df12b8
to
c9eab4a
Compare
decabeza
force-pushed
the
foundation-update
branch
from
c9eab4a
to
9f80b43
Compare
This was referenced Jun 6, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
This PR updates
foundation-rails gem(and closes #2210) 馃帀Visual Changes
There is no visual changes. Only some HTML classes uptaded to maintain the same layout. But now we are updated with the lastest Foundation version this allows use the functionallity described on #2210
Notes for release
At the moment we keep using Foundation grid (legacy) and the new Foundation XY Grid it has been commented on
foundation_and_overrides.scss(many necessary changes throughout the code, it will be ready on upcoming releases!)