Split spec common actions support helper #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitbw
reviewed
May 28, 2018
| module Budgets | ||
| # spec/features/budgets/ballots_spec.rb | ||
| def expect_message_organizations_cannot_vote | ||
| #expect(page).to have_content 'Organisations are not permitted to vote.' |
There was a problem hiding this comment.
If this expectation is not being used, I think it'd be better to remove it altogether
aitbw
reviewed
May 28, 2018
spec/support/common_actions/users.rb
Outdated
| visit new_officing_residence_path | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
Please, remove this trailing line
|
Besides those small annotations, great job @aamarill ! 馃帀 |
|
Sorry for the delay! Let me know if I missed anything 馃槃 |
|
Awesome! Thanks @aamarill 馃帀 |
|
It was truly a pleasure to work with you all 馃槃 馃檹 Thank you for your words of encouragement and support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for issue #2644 posted by @voodoorai2000.
Notes
Thanks! 馃檶