Deal gracefully with hidden followable in my activity #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were seeing an exception when a user was following a proposal and that proposal becomes hidden With this commit we are skipping this proposals and hopefully fixing this exception We are also adjusting the count of followed proposals, without including hidden proposals. It might be cleaner, to remove a `Follow` when its `Followable` becomes hidden. But then we should probably activate the `Follow` again if the `Followable` becomes non-hidden… For now this commit should suffice 😌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is a backport of AyuntamientoMadrid#1466
Related issue: AyuntamientoMadrid#1462
Objectives