Custom fields on legislation proposals

[jaflutz]

References

Closes #3184 - Custom fields on legislation proposals

Objectives

Enables admins to customize the fields of legislation proposals. It makes possible to select which fields are shown to the users and to change the label of the fields.

Visual Changes

Changes in the admin view:

Changes in the users view:

[microweb10]

Hi @jaflutz, thank you very much for this PR!!! 😍 🎉

First of all, my apologies for the late feedback 🙏
Then, just a couple of things:

• For consistency with the rest of the code, we have introduced some rubocop rules and we use double quotes everywhere, could you please check the Hound alerts and update them using double quotes? 🙏
• Correct me if I’m wrong, but if you add default: true to the first migration, the second one is not needed ☺️
• Could you use let instead of let! here? 🙏
• We normally use build for model validations, instead of create, could you use build here and here? ☺️
• We prefer to define these kinds of methods in the model when possible.
  Would you mind to try to define them in the model? 🙏 Maybe something like:

def title_label
  self.title_label || self.title_label_value
end

• I think these checked attributes should not be necessary. Rails should be smart enough to take the value according to the input name. Could you try to delete them and check if it still works as expected? 🙏

You may also want to do a rebase with master since we have introduced a lot of code and now there are some conflicts in order to merge the code in the master branch. 🙂

Please let me know what do you think and if you have any concern about this ☺️

[jaflutz]

Hi @microweb10!
So sorry for so many amateur mistakes 😳
I'll try to get them fixed and rebase this PR as soon as I can!

[jaflutz]

Strange, I don't see these errors in travis-ci from my fork. 😕 It seems they're not related with the changes in this PR. Or am I wrong? Any ideas?
Thanks!

[javierm]

@jaflutz They're not related to this pull request. Sorry! 🙏. We think we know the cause; we're working on fixing it 😄.

[javierm]

@jaflutz Fixed by #3534 😄.

[jaflutz]

Oh, great! 😌
I've just realized I don't know how to fire up travis-ci without pushing again 😬
Thanks @javierm !

[javierm]

@jaflutz Very sorry for the late reply! 🙏 And very sorry we're actually closing this pull request 😬

Before doing so, I'd like to really thank you for this pull request, for adding tests, and for taking the time to follow our code conventions. Really appreciate it, and that's why I'm really sorry to close the pull request.

The thing is, we haven't worked on legislation processes so much during the last two years and a half and are currently wondering what to do about this section. Until we reach a decision (which, given our current pace, could take quite some time), we aren't adding this feature regarding custom fileds.

Thank you very much and, once again, sorry. All the best!