Add ERB Lint configuration file #3379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rubocop linter cannot use the `rubocop_config` option because it's not compatible with Ruby 2.3. So we're setting the rubocop rules manually.
javierm
force-pushed
the
backport-erb_lint
branch
from
02c052a
to
f30afab
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Automatically detect syntax not following our code conventions in ERB files.
Notes
The rubocop linter cannot use the
rubocop_configoption because it's not compatible with Ruby 2.3. So we're setting the rubocop rules manually. HoundCI doesn't seem to warn about those rules, though, even if ERB Lint correctly warns about them when running locally 馃.