Commits on Apr 10, 2019

1. Respond with 404 when confirming an invalid token …

   We were getting a 500 Internal Server Error because `find_by` returned
   `nil`, but the code assumed it returned an object responding to
   `encrypted_password`. In this case, maybe some other status code (like
   400 or 401) might be more appropriate, but I've kept 404 because it was
   easier to implement and I wasn't sure which one was better.
   
   Also note ideally we would test the controller using:
   
   expect(response).to have_http_status(:not_found)
   
   However, we would need to configure the test to show exceptions and not
   to consider all requests local. I haven't been able to do so for
   controller tests, and doing so for feature/request specs seems to
   require changes in the test environment configuration which would affect
   other tests.

   

   javierm committed Apr 10, 2019
   Copy the full SHA

   78c6395 View commit details

   Browse the repository at this point in the history