Simplify after blocks in specs #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
remove_after_blocks
branch
2 times, most recently
from
64db5fa
to
ce2c9eb
Compare
Settings are stored in the database, and so any changes to the settings done during the tests are automatically rolled back between one test and the next one. There were also a few places where we weren't using an `after` block but changing the setting at the end of the test.
We already configure `I18n.locale` and we reset Globalize's fallbacks before every test. On the other hand, RSpec automatically resets anything which is stub with `allow`, so there's no need to use `and_call_original` in an `after` block.
Among other advantages, now we can run these tests with `rspec --tag delayed_jobs`.
javierm
force-pushed
the
remove_after_blocks
branch
from
ce2c9eb
to
233d2e2
Compare
taitus
approved these changes
Sep 23, 2019
These settings are enabled by default. It could be argued explicitely enabling the features makes tests more consistent, because they'll work if we change the default setting. It could also be argued that it makes tests more expressive because it makes the reader realize certain things will only work if a setting is enabled. However, we were only doing so in a few tests. The truth is, thousands of our tests depend on certain features being enabled. So IMHO we should be consistent and either set them on every test, or not at all. I'm choosing the latter option for simplicity.
javierm
force-pushed
the
remove_after_blocks
branch
from
233d2e2
to
2ec176a
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Simplify after blocks in specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
afterblocks cleaning up the databasebeforeandafterblocks in tests using delayed jobs