Remove tasks executed in version 1.0.0 #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
prepare_1.1_tasks
branch
2 times, most recently
from
cb5a9d8
to
d03efd0
Compare
These tasks were executed when upgading to version 0.19, 1.0.0-beta or 1.0.0.
I was thinking of leaving these tasks empty, so in the future we could use them again if we rename or remove more settings. But since we haven't renamed nor removed any settings for more than seven months, and we've only used these tasks once, I'm simply removing the tasks. It's easy to add them back if we ever need them.
Although it's already executed when deploying with capistrano, heroku installations don't use capistrano for deployment, so we're also executing it when upgrading. This isn't a one-time task, so it makes sense to have it executed on every release.
javierm
force-pushed
the
prepare_1.1_tasks
branch
from
d03efd0
to
17a400a
Compare
It now contains tasks we've added after version 1.0.0
This way there'll be no side effects if accidentally executed on data already having the `original_heading_id`.
javierm
force-pushed
the
prepare_1.1_tasks
branch
from
17a400a
to
4fad6f1
Compare
The pull request adding the original heading was done before we started using `ApplicationLogger` in rake tasks.
javierm
force-pushed
the
prepare_1.1_tasks
branch
from
821b701
to
0a2efb1
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Remove tasks executed in version 1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives