Fix blank space in admin content #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
fix_equalizer_investments
branch
12 times, most recently
from
d0313a7
to
3f974fc
Compare
javierm
force-pushed
the
fix_equalizer_investments
branch
2 times, most recently
from
f7f4dd2
to
245e74e
Compare
javierm
force-pushed
the
fix_equalizer_investments
branch
3 times, most recently
from
d841421
to
b073fbf
Compare
In some situations where JavaScript makes content disappear, the height of the element calculated by foundation's equalizer isn't recalculated, leaving blank space at the bottom of the page. I've seen cases where a blank vertical space of 2000 pixels is on the page. Using flexbox solves the problem, since CSS takes care of everything.
We can move the button to toggle the menu to the main content, and everything will look the same way while we'll need one div less.
We were using `overflow: scroll` as a workaround with a problem we had with the equalizer. But now we never need an extra vertical scroll bar, and we only need an extra horizontal scroll bar on small screens. Since the dashboard was using the class `admin-content` as well, we need to apply to the dashboard the same changes we've done in the admin section. I've extracted them into a mixin.
javierm
force-pushed
the
fix_equalizer_investments
branch
from
b073fbf
to
42106e6
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…estments Fix blank space in admin content
This was referenced May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Visual Changes
Before this change:
Using the browser's back button:
After this change:
Using the browser's back button: