Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in several environments #3791

Merged
merged 5 commits into from
Oct 23, 2019
Merged

Fix warnings in several environments #3791

merged 5 commits into from
Oct 23, 2019

Commits on Oct 23, 2019

  1. Fix extra parameter in have_link 

    The second parameter was ignored. Besides, we changed the place where
the link pointed to in commit fcbb11b.
    @javierm
    javierm committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    13793d8 View commit details
    Browse the repository at this point in the history

  2. Bump parser to 2.6.5.0 

    This version is compatible with Ruby 2.4.9.
    @javierm
    javierm committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    48cbb93 View commit details
    Browse the repository at this point in the history

  3. Fix modal text warning in answers documents spec 

    It looks like we get this warning if we check the dialog message. Using
`accept_confirm` the same way we do in the rest of the application
solves the problem.
    @javierm
    javierm committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    b0d1d00 View commit details
    Browse the repository at this point in the history

  4. Remove redundant scopes 

    These scopes were already defined by the `enum :task` method.
    @javierm
    javierm committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    26e050b View commit details
    Browse the repository at this point in the history

  5. Avoid "Overwriting existing method open" warning 

    In Ruby, the Kernel class defined the `open` method, which is available
for (almost) every object. So creating a scope with the name `open`
generates a warning indicating we are overwriting the existing `open`
method.

While this warning is pretty much harmless and we could ignore it, it
generates a lot of noise in the logs. So I'm "undefining" the method
before generating the scope, so we don't get the warning all the time.
    @javierm
    javierm committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    69e3e67 View commit details
    Browse the repository at this point in the history