Update chromeOptions for newer versions of chromedriver #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
It works on my machine with chromedriver 2.40, and according to chromdriver's release notes, it works since version 2.31. Since we already require chromedriver >= 2.33 in our README, I don't see a reason not to merge this pull request 😄.
microweb10
force-pushed
the
chromedriver_upgrade
branch
from
c6cc0c9
to
cb3a1f2
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Update chromeOptions for newer versions of chromedriver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
When using a newer version of
chromedriver, the attribute name forchromeOptionshas changed, so a new attribute name (goog:chromeOptions) needs to be used.Notes
We don't have to merge this PR, but I wanted to create it so people using a newer version of☺️
chromedrivercan have a reference.