Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations from Crowdin #3883

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

Senen
Copy link
Member

@Senen Senen commented Dec 11, 2019

References

Related PR: #3881

Objectives

Update translations from Crowdin.

This PR includes a commit to fix specs that were failing after adding translations.

Notes

I used following script to know the status of translations for all locales (49).

#!/bin/bash
fake_locales_folders=(   ban    bn    bs    cs    da    de    el    eu    fa    fi    hr    hu    id    mk    pap     pl    ro    sh    si    sl    so    sq    sr    sv    tr    yi)
to_hack_locales_folders=(ban-ID bn-BD bs-BA cs-CZ da-DK de-DE el-GR eu-ES fa-IR fi-FI hr-HR hu-HU id-ID mk-MK pap-pap pl-PL ro-RO sh-HR si-LK sl-SI so-SO sq-AL sr-CS sv-SE tr-TR yi-DE)

# Move fake locales folders to real ones
for((i=0;i<${#fake_locales_folders[@]};i++))
do
  echo "Move fake locales folders to real ones"
  mv config/locales/${fake_locales_folders[$i]} config/locales/${to_hack_locales_folders[$i]}
  echo "Moved folder from: config/locales/${fake_locales_folders[$i]} to config/locales/${to_hack_locales_folders[$i]}"
done

# Move real locales folders to fake ones
for((i=0;i<${#to_hack_locales_folders[@]};i++))
do
  echo "Move real locales folders to fake ones"
  mv config/locales/${to_hack_locales_folders[$i]} config/locales/${fake_locales_folders[$i]}
  echo "Moved folder from: config/locales/${to_hack_locales_folders[$i]} to config/locales/${fake_locales_folders[$i]}"
done

# Run some i18n-tasks for all existing languages
for locale in ar ast ban bn bs ca cs da de el en en-GB en-US es es-PE eu fa fi fr gl he hr hu id it mk nl nn nn pap pl pt pt-BR ro ru sh si sl so sq sr sr sv-FI sv tr val yi zh-CN zh-TW
do
  echo "Checkin locale: $locale"
  # i18n-tasks missing -l $locale
  # i18n-tasks unused -l $locale
  i18n-tasks check-consistent-interpolations -l $locale
done

After organizing the output of different executionsof the script above i put all the information toghether on a table to be able to see the evolution of each locale:

Folder Locale Missing (master) Unused (master) Inconsistent Interpolations (master) Missing (i18n_crowdin) Unused (i18n_crowdin) Inconsistent Interpolations (i18n_crowdin)  Conclusion  
  ar 731 331 16 229 0 23 Better  
  ast 1433 0 5 1433 0 0 Stale  
ban-ID ban - - 0 3312 0 0 New New language
bn-BD bn 3261 0 0 3261 0 0 Stale Conflict
bs-BA bs 630 356 0 621 0 0 Better  
  ca 1485 307 5 1482 0 0 Better  
cs-CZ cs 773 363 0 781 12 0 Worse  
da-DK da 412 377 0 276 1 0 Better  
de-DE de 730 352 0 5 0 0 Almost perfect  
el-GR el 343 379 0 289 0 0 Better  
  en 0 0 0 0 0 0 Almost perfect  
  en-GB 3310 0 0 3310 0 0 Stale Conflict
  en-US 3275 5 0 3275 0 0 Better Conflict
  es 0 0 1 0 0 0 Almost perfect  
  es-PE 1137 331 5 1135 0 0 Better  
  eu-ES 3196 9 0 3196 0 0 Better  
fa-IR fa 1197 316 0 1201 0 0 Better  
fi-FI fi 2249 124 0 2237 0 0 Better  
  fr 580 358 14 585 0 0 Worse  
  gl 712 354 8 510 0 0 Better  
  he 330 375 9 244 0 0 Better  
hr-HR hr 921 297 0 380 0 0 Better  
hu-HU hu 3312 0 0 3312 0 0 Stale Conflict
id-ID id 954 348 0 957 3 0 Better  
  it 834 348 8 563 0 0 Better  
mk-MK mk 3251 7 0 3251 0 0 Better Conflict
  nl 639 355 6 644 0 0 Worse  
  nn 3289 1 0 2608 0 13 Better Conflict
nn-NO nn 3312 0 0 2608 0 13 Stale Conflict
pap-PAP pap 3310 0 0 3310 0 0 Stale Conflict
pl-PL pl 682 354 0 684 0 0 Better  
  pt 3312 0 0 3312 0 0 Stale Conflict
  pt-BR 804 352 11 638 2 0 Better  
ro-RO ro - - 0 3312 0 0 New New language
  ru 703 355 5 299 4 0 Better  
sh-HR sh 3312 0 0 3312 0 0 Stale Conflict
si-LK si - - 0 3312 0 0   New language
sl-SI sl 1245 328 0 1243 11 0 Better  
so-SO so 800 352 0 803 0 0 Better  
sq-AL sq 789 352 0 793 0 0 Better  
sr-CS sr 3312 0 0 3312 0 0 Stale Conflict
sr-SP sr 3312 0 0 3312 0 0 Stale Conflict
  sv-FI 3296 0 0 3294 0 0 Better Conflict
sv-SE sv 712 356 0 543 2 1 Better  
tr-TR tr 628 362 0 230 0 0 Better  
  val 746 353 9 751 0 0 Worse  
yi-DE yi 3312 0 0 3312 0 0 Stale Conflict
  zh-CN 787 355 6 791 3 0 Better  
  zh-TW 807 355 5 811 3 0 Better  

@Senen Senen self-assigned this Dec 11, 2019
@Senen Senen changed the title [WIP] Update translations from Crowdin Update translations from Crowdin Dec 11, 2019
@Senen Senen changed the title Update translations from Crowdin [WIP] Update translations from Crowdin Dec 11, 2019
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Senen Awesome 🎉. I'm so glad this time crowdin didn't reintroduce the wrong interpolation parameters 😄.

I've left a couple of comments. Let me know what you think!

spec/shared/features/remotely_translatable.rb Show resolved Hide resolved
config/locales/es/activerecord.yml Outdated Show resolved Hide resolved
config/locales/es/activerecord.yml Outdated Show resolved Hide resolved
config/locales/ar/rails.yml Outdated Show resolved Hide resolved
@Senen Senen changed the title [WIP] Update translations from Crowdin Update translations from Crowdin Dec 18, 2019
@Senen Senen requested a review from javierm December 18, 2019 15:33
@Senen Senen changed the title Update translations from Crowdin [WIP] Update translations from Crowdin Dec 18, 2019
New deutsch translations of remote translations
interface have broke these specs where we were
using English translations at specs to do the checks
while the spec interface was in deutsch and now we
have deutsch translations for the interface application
is not returning english fallbacks anymore and a lot of
specs of this file fails.

This commits also changes the alternative language
used at spec from deutsch to spanish which is
maintaned by code not through Crowdin, so if any
developer update current spanish translations for the
user interface this specs will fail.
@Senen Senen changed the title [WIP] Update translations from Crowdin Update translations from Crowdin Dec 18, 2019
@javierm javierm added this to Reviewing in Roadmap via automation Dec 18, 2019
Roadmap automation moved this from Reviewing to Testing Dec 18, 2019
@javierm javierm merged commit 309c86b into consuldemocracy:master Dec 19, 2019
Roadmap automation moved this from Testing to Release 1.1.0 Dec 19, 2019
@Senen Senen mentioned this pull request Dec 20, 2019
@javierm javierm self-assigned this Feb 19, 2020
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Roadmap
  
Release 1.1.0
Development

Successfully merging this pull request may close these issues.

None yet

3 participants