-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translations from Crowdin #3883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 11, 2019
javierm
requested changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Senen Awesome 🎉. I'm so glad this time crowdin didn't reintroduce the wrong interpolation parameters 😄.
I've left a couple of comments. Let me know what you think!
New deutsch translations of remote translations interface have broke these specs where we were using English translations at specs to do the checks while the spec interface was in deutsch and now we have deutsch translations for the interface application is not returning english fallbacks anymore and a lot of specs of this file fails. This commits also changes the alternative language used at spec from deutsch to spanish which is maintaned by code not through Crowdin, so if any developer update current spanish translations for the user interface this specs will fail.
javierm
approved these changes
Dec 18, 2019
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Update translations from Crowdin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related PR: #3881
Objectives
Update translations from Crowdin.
This PR includes a commit to fix specs that were failing after adding translations.
Notes
I used following script to know the status of translations for all locales (49).
After organizing the output of different executionsof the script above i put all the information toghether on a table to be able to see the evolution of each locale: