Fix card description overflow #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edumoreira1506
force-pushed
the
fix/card-description
branch
from
4071a81
to
9f0dcf3
Compare
edumoreira1506
force-pushed
the
fix/card-description
branch
from
9f0dcf3
to
9f948c1
Compare
decabeza
approved these changes
Feb 18, 2020
|
Thanks for the fix! 🙏 😉 |
|
@edumoreira1506 Thanks a lot! 😄 |
|
The failing test doesn't seem to be related to this pull request; I'll have a look at it. |
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…description Fix card description overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
https://demo.consulproject.org/
Objectives
This PR fixes a bug that was caused when a card had a big description.
Visual Changes
Before:
After:
