Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused tag filter #3966

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Remove unused tag filter #3966

merged 1 commit into from
Apr 9, 2020

Conversation

javierm
Copy link
Member

@javierm javierm commented Apr 8, 2020

References

Objectives

  • Remove unused code

Notes

This filter could actually be useful if we started using it when users click on a tag. Since we don't, I'm removing it. We might add it back if we decide to actually use it.

This filter was added in commit 4285ba4, it was changed in commit
002d868, and most of the code from the original commit has disappeared
without a trace (maybe due to a merge conflict?).

This filter could actually be useful if we started using it when users
click on a tag. Since we don't, I'm removing it. We might add it back if
we decide to actually use it.
@javierm javierm self-assigned this Apr 8, 2020
@javierm javierm added this to Reviewing in Consul Democracy via automation Apr 8, 2020
@javierm javierm merged commit b568236 into master Apr 9, 2020
Consul Democracy automation moved this from Reviewing to Release 1.2.0 Apr 9, 2020
@javierm javierm deleted the remove_unused_filter branch May 26, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants