Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment responses count when adding replies #4003

Merged
merged 4 commits into from
May 26, 2020
Merged

Update comment responses count when adding replies #4003

merged 4 commits into from
May 26, 2020

Commits on May 26, 2020

  1. Update parent comment responses count when a new reply is created 

    Extract the needed portion of code to a new partial to be able to update
only the elements needed when a new comment is added keeping UI properly
updated.
    @Senen
    Senen committed May 26, 2020
    Configuration menu
    Copy the full SHA
    956f002 View commit details
    Browse the repository at this point in the history

  2. Add mutations observer to initialize user initials added through ajax

    @Senen
    Senen committed May 26, 2020
    Configuration menu
    Copy the full SHA
    014fa6e View commit details
    Browse the repository at this point in the history

  3. Show parent comment responses when a new reply is added 

    When a user replies to a comment whose responses was hidden at the
moment of reply form submission and although the reply were correctly
added to the DOM it was hidden because was added to a collapsed list.

This solution is about showing all responses of parent comment after adding
the new comment to the DOM so the user can see new reply into the screen.
(This is not applicable to root comments which cannot be collapsed)
    @Senen
    Senen committed May 26, 2020
    Configuration menu
    Copy the full SHA
    dcff7e8 View commit details
    Browse the repository at this point in the history

  4. Improve the way to toggle comment responses 

    Co-Authored-By: Javi Martín <javim@elretirao.net>
    @Senen @javierm
    Senen and javierm committed May 26, 2020
    Configuration menu
    Copy the full SHA
    31c0b43 View commit details
    Browse the repository at this point in the history