Don't use confirm dialog in admin homepage form #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case the confirmation dialog isn't really necessary since the action to enable/disable the setting can easily be undone. Furthermore, these tests were failing with Chrome 83, probably because we use `confirm_dialog` and then we use `visit` without checking the page in between. In theory we shouldn't need to check the page in between because the request generated by `confirm_dialog` is a synchronous one and so `visit` isn't executed after the previous request has finished, but apparently this behavior has changed in Chrome 83. We could add an expectation before executing the `visit` method, but that wouldn't improve the usability of the application.
javierm
force-pushed
the
homepage_confirm_dialog
branch
from
a50c00b
to
5bf968d
Compare
taitus
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Notes
These tests were failing with Chrome 83, probably because we use
confirm_dialogand then we usevisitwithout checking the page in between.In theory we shouldn't need to check the page in between because the request generated by
confirm_dialogis a synchronous one and sovisitisn't executed after the previous request has finished, but apparently this behavior has changed in Chrome 83.We could add an expectation before executing the
visitmethod, but that wouldn't improve the usability of the application.