Show Wordpress login button if it's the only one enabled #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were writing the same code twice, with the only difference being the text "Sign up" in the sign_up action, and "Sign in" in the sign_in action. Note we're renaming the `omniauth.info_*` I18n keys so we don't need to add new exceptions to the `ignore_unused` list, and so it's consistent with all the other keys under the `omniauth` key.
Since we're using the exact same logic for all existing buttons, we can just get the list of available ones and loop through them.
We were adding the same styles five times.
taitus
approved these changes
Aug 5, 2020
javierm
approved these changes
Aug 6, 2020
|
Cool! Thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Wordpress login was introduced in PR #3902 but a BUG was also introduced, the button will not appear if Wordpress login is the only one external authentication feature enabled.
Objectives