Simplify Javascript code #4073
Merged
Simplify Javascript code #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use delegated handlers instead so there is not risk to run method multiple times.
By using an event delegation handler on document body there is no need to check if element was already initialized (idempotency) anymore.
There is no elements with class `js-participation-allowed` within all application code.
TableSortable and Sortable javascripts were using the same CSS class name to define completely different and separated behaviours causing unexpected errors. Now `sortable.js` script will use `.sortable` class and `table_sortable.js` will use `.table-sortable` instead.
Closed
Its known that initializing a map when it is inside a hidden element wont work when hidden element is shown, so its makes sense to avoid initialization of hidden maps. When a map lives within a hidden layer we need to initialize the map after the event of showing that hidden layer, in our case when admin settings tab is shown.
In the past we had huge problems trying to make it work with Turbolinks. However, after updating foundation-rails in commit 58071fd, these hacks aren't necessary anymore. We're adding a test for the scenario of visiting a page using Turbolinks, which was missing, so we're sure we aren't breaking anything. Note the sticky will still not work after using the browser back button. We haven't been able to make it work with turbolinks-classic; we'll fix this issue when upgrading turbolinks.
The `$()` function is a shortcut for `$(document).ready()`, and we were attaching events to `$(document).ready()` inside the `$()` function. In a similar way, we were handling the `page:load` and `ajax:complete` events inside the `$()` function. But when those events trigger, the DOM is already ready. Besides, we don't have to wait for the DOM to be ready before attaching events to the `document` element. Quoting jQuery's `.on()` documentation: > The document element is available in the head of the document before > loading any other HTML, so it is safe to attach events there without > waiting for the document to be ready. Co-Authored-By: Senén Rodero Rodríguez <senenrodero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related PR: Turbolinks 5 fixes #4071
Objectives
Add some javascript fixes for errors found during manual testing of all application javascript.