Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix advanced search filter button position #4299

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Conversation

javierm
Copy link
Member

@javierm javierm commented Dec 28, 2020

References

Objectives

Fix the advanced search filter button position so it's where it was in version 1.0.

Visual Changes

Before these changes

The filter button appears between two elements

After these changes

The filter button appears at the end of the form

This bug was introduced when foundation changed some of its rules
regarding when to clear floats, probably in commit 58071fd.
@javierm javierm self-assigned this Dec 28, 2020
@javierm javierm added this to Reviewing in Consul Democracy via automation Dec 28, 2020
@taitus taitus self-assigned this Dec 28, 2020
Consul Democracy automation moved this from Reviewing to Testing Dec 28, 2020
@javierm javierm merged commit da0a4ae into master Dec 28, 2020
Consul Democracy automation moved this from Testing to Release 1.3.0 Dec 28, 2020
@javierm javierm deleted the fix_filter_button branch December 28, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants