Refactor tags and SDG "tags" rendering #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can skip the `link_to(*options) if options` part if we accept anchor tags in the `link_list` helper.
javierm
force-pushed
the
sdg_list_refactor
branch
from
1a60181
to
a55db41
Compare
This is more consistent with the "tag_cloud" partial name.
So now we've got a component receiving records (goals or targets) and a related model (Debate, Proposal, ...), with optionally a link to see more tags. This way we simplify some logic since the `TagList` classes were dealing with too many cases (a record is passed, a class name is passed, a limit is passed), ... Now `TagList` only deal with the natural `TagList` case, which is listing the tags for a record. The case where a class name is passed is used in the `TagCloud` class.
javierm
force-pushed
the
sdg_list_refactor
branch
from
a55db41
to
7d4e49a
Compare
javierm
changed the title
taitus
approved these changes
Feb 3, 2021
Senen
approved these changes
Feb 4, 2021
This rule was added so the tag list wouldn't have an extra bottom margin. However, the rule is already applied by the `.tags` selector inside `.budget-investment` and it was conflicting with other lists (goals and tags) we've added to thi investments index.
javierm
force-pushed
the
sdg_list_refactor
branch
from
157ef39
to
92a09f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives