Improve the management of related content #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
taitus
force-pushed
the
related-content-exist
branch
from
6a32089
to
3f2a553
Compare
taitus
force-pushed
the
related-content-exist
branch
from
3f2a553
to
ec7f1a1
Compare
javierm
reviewed
Jun 25, 2021
taitus
force-pushed
the
related-content-exist
branch
from
ec7f1a1
to
29d2e2a
Compare
javierm
approved these changes
Jun 25, 2021
It looks like this bug was introduced in commit 7ca55c4. Before that commit, a message saying "You added a new related content" was shown, but (as expected) the related content wasn't added twice. We now check this case and add a slightly clearer message.
javierm
force-pushed
the
related-content-exist
branch
from
29d2e2a
to
ee66c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related PR: #3780
Closes #4498
Objectives
We detect when we add related content that already exists and display a slightly clearer message.