Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky legislation draft version spec #4682

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Conversation

javierm
Copy link
Member

@javierm javierm commented Aug 29, 2021

References

Failure

1) Admin legislation draft versions Create Valid legislation draft version
   Failure/Error: click_link "Drafting"

   Capybara::ElementNotFound:
     Unable to find link "Drafting"

Objectives

  • Make the test pass 100% of the time

Notes

The test was failing sometimes, probably because the "Edit" link within the "An example legislation process" row is already present before clicking the "All" link. This can lead to simultaneous requests.

Just removing the unnecessary click on the "All" link solves the issue.

The test was failing sometimes, probably because the "Edit" link within
the "An example legislation process" row is already present before
clicking the "All" link. This can lead to simultaneous requests.

Just removing the unnecessary click on the "All" link solves the issue.
@javierm javierm self-assigned this Aug 29, 2021
@javierm javierm added this to Reviewing in Consul Democracy via automation Aug 29, 2021
Consul Democracy automation moved this from Reviewing to Testing Sep 3, 2021
@Senen Senen self-assigned this Sep 3, 2021
@javierm javierm merged commit df623f3 into master Sep 3, 2021
@javierm javierm deleted the flaky_drafting_spec branch September 3, 2021 09:46
Consul Democracy automation moved this from Testing to Release 1.4.0 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants