Add dockerignore file #4765
Merged
Add dockerignore file #4765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
docker_ignore
branch
from
58aedf6
to
16f1540
Compare
javierm
force-pushed
the
docker_ignore
branch
from
16f1540
to
4a44f55
Compare
taitus
approved these changes
Jan 10, 2022
This was referenced Mar 29, 2022
Open
We don't use SQLite and we don't support it, so these files shouldn't exist in the first place.
This feature was removed in commit 1e0ac13.
We can't cover the files for every editor out there, so we're removing it in the name of neutrality. Developers using this editor to work with CONSUL can add the `.idea` to their global gitignore configuration (on GNU/Linux systems, for instance, the `~/.config/git/ignore` file).
We used a slash as a prefix in some cases but not in other cases. Now we're defining files and folders following the gitignore rules: files starting with a slash are only ignored in the root folder, while files not starting with it are ignored everywhere. IMHO it makes sense to ignore all folders named `tmp`, `.bundle`, `log`, `.DS_Store` or `.ruby-gemset` everywhere in the source code and not only in the root folder. We're also adding a trailing slash to all folders for consistency.
So it's easier to follow.
Note there's a difference between gitignore and dockerignore; in .gitignore, files without a leading slash match files in every folder, while in .dockerignore, they match files in the root folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
.gitignorefile.gitignorefile so it's easier to read