Fix generating dashboard poster on production #4767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 905ac48 we mentioned: > Since we don't use `asset_path` to reference assets in the public > folder, we can safely disable the `unknown_asset_fallback` option. However, `asset_path` is used by the wicked_pdf gem when calling the `wicked_pdf_stylesheet_link_tag` method. This method also checks the CSS files, searching for `url()` calls and converting any relative URLs referenced there to absolute URLs. However, when compiling assets on production, our `application.css` file contains the following line imported from Leaflet which says: ``` behavior: url(#default#VML); ``` When passing this URL to `asset_path` (which is something the wicked_pdf gem does automatically), it doesn't find the URL, and so this call crashes unless we enable then `unknown_asset_fallback` option. Since the dashboard poster is a feature we might remove in the future, we're avoiding changing a Rails global configuration just for this feature. So, instead of enabling the `unknown_asset_fallback` option, we're changing the `poster.pdf` view so it doesn't load all the CSS of the application but only the CSS it needs. Note we aren't adding a test case because this bug is only present on production environments when assets have been precompiled.
javierm
force-pushed
the
poster_asset_path
branch
from
a6fec0b
to
c5103d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Fix a bug which made it impossible to generate the proposals dashboard poster on production environments.
Notes
We aren't adding a test case because this bug is only present on production environments when assets have been precompiled.