Add offline ballot sheet votes to the total vote count

[jorgebg]

References

A few days ago I was trying the offline votes upload form (ballot sheet), and noticed that the votes were not being included into the total vote count of the budget investments showed in the results page. I thought this could possible be a bug.

Objectives

Add the ballot sheet votes to the total vote count of participatory budgeting investments.

Context

Note: Please let me know if I'm missing something, I'm pretty new to Consul, and I'm a RAILS newbie as well.

If I understood properly, offline votes of participatory budgeting must be uploaded via the ballot sheet CSV data form. I tried this form on my local installation, and the ballot sheet was uploaded, but the votes were not added to the total count of the investments votes showed in the results page.

Poll::BallotSheet.verify_ballots is the method that takes care of registering the votes for a given ballot sheet. After searching the code, the only reference I found to this method was in its spec, where it was being called explicitely.

Now, I'm not aware of any RAILS API making implicit calls to this method (with my little RAILS ecosystem knowledge). If neither the app code or the 3rd party libraries are calling it, then how are these votes being counted in?

Implementation details

• Added the Poll::BallotSheet.verify_ballots to the Active Record after_create callback, so the votes are added right after ballot sheet creation.
• Removed the explicit call to Poll::BallotSheet.verify_ballots from the spec.

Visual Changes

None

Notes

None

[jorgebg]

@javierm @voodoorai2000 @taitus @Senen I'm sorry for the mentions but I think this could be an important bug (I'm inexperienced so I might be wrong though, but I prefer to trigger a false alarm rather than a late alarm)

[javierm]

Hi, @jorgebg 😄. Thank you for the pull request! We'll have a look when we've got time (probably not this week, though).

[jorgebg]

Hi @javierm! Looks like the linter check failed. I think it's related to the way it checks out the repository, but I'm not sure. Please, can you trigger it again, just in case it was a temporary error? Thanks in advance!

[javierm]

Hi, @jorgebg 😄.

Yes, that's driving us crazy 😅. It tooks us about five attempts until we finally made it possible to run linters on pull requests by contributors like you, and then there was a change in Github Actions and it isn't working anymore. If you've got experience with this issue and know the solution, pull requests are welcome!

I've run the linters locally; you can do so too by running bundle exec pronto run on your machine. Here's the result:

spec/models/poll/ballot_sheet_spec.rb:5 W: Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)

[jorgebg]

Thank you, @javierm. I'm sorry, unfortunately I couldn identify the issue with Github Actions.

I removed the empty line pronto was complaining about. Not sure if pronto is working properly in my local dev, as I got no output after running it. The exit code was 0, though. If the linter still complains I'll take a look to my pronto installation.

[javierm]

@jorgebg Pronto displays no output locally when everything is alright 👌; it you checkout the commit having the extra blank line and execute pronto run, you should get the output I mentioned earlier.

[javierm]

@jorgebg Thank you once again for the bug report and the pull request 🎉.

The changes look good to me 👍. I've updated the pull request to our latest master branch and expanded it a little bit by adding a system spec to verify the votes are taken into account when calculating the winners.

We need to test a couple more things. As soon as we verify them, we'll merge this pull request 👍.

[jorgebg]

I'm so glad this worked out! Thanks for reviewing it, @javierm, @taitus. So happy to help!