Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background image from Participatory Budgets page #4814

Merged
merged 1 commit into from
May 3, 2022

Conversation

iraline
Copy link
Contributor

@iraline iraline commented Apr 27, 2022

References

Closes #4786

Objectives

Allow to use a full background image in Participatory Budgeting

Visual Changes

image

Notes

In the issue description, it is informed about the Foundation class already allowing this effect. However, in the file /app/assets/stylesheets/layout.scss it is possible to notice that there is a limitation in the body with the value of $body-margin .This value is set in the file app/assets/stylesheets/_consul_settings.scss , thus preventing the image from expanding to the entire background width. To fix it, tests were done and the best way found was to add the z-index to the budget-header

@javierm javierm added this to Reviewing in Consul Democracy via automation Apr 27, 2022
@iraline
Copy link
Contributor Author

iraline commented Apr 29, 2022

I don't understand why the check is falling 🤔

@javierm
Copy link
Member

javierm commented Apr 29, 2022

@iraline Very sorry for that! 🙏 At a certain point, there was a change in GitHub Actions on pull requests done by people who don't have write access to the repository. Since then, we haven't been able to run the linters in these cases. We still haven't found how to fix the issue (ideas are welcome! 😉)

You can manually run the linters on your machine and check everything is OK with pronto run.

@javierm javierm self-assigned this May 3, 2022
@javierm javierm added the Bug label May 3, 2022
@javierm javierm changed the title Fixing background image from Participatory Budgets page - #4786 Fix background image from Participatory Budgets page May 3, 2022
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iraline Great, thanks! 🎉 Creating a new stacking context so the background is behind the background of the ::before pseudoelement works indeed 👍.

Consul Democracy automation moved this from Reviewing to Testing May 3, 2022
@javierm javierm merged commit d05fa80 into consuldemocracy:master May 3, 2022
Consul Democracy automation moved this from Testing to Release 1.5.0 May 3, 2022
@javierm
Copy link
Member

javierm commented May 3, 2022

@iraline Very sorry! 🙏 I noticed an issue right after merging the pull request. I've opened pull request #4825 to fix it.

@iraline iraline deleted the fix_background_4786 branch May 4, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full background images in Participatory Budgets
2 participants