-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rubocop-rails from 2.11.3 to 2.15.2 #4911
Merged
javierm
merged 3 commits into
master
from
dependabot/bundler/master/rubocop-rails-2.15.2
Aug 25, 2022
Merged
Bump rubocop-rails from 2.11.3 to 2.15.2 #4911
javierm
merged 3 commits into
master
from
dependabot/bundler/master/rubocop-rails-2.15.2
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bad3328
to
a95390a
Compare
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.11.3 to 2.15.2. - [Release notes](https://github.com/rubocop/rubocop-rails/releases) - [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rails@v2.11.3...v2.15.2) --- updated-dependencies: - dependency-name: rubocop-rails dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
This rule was added in rubocop-rails 2.12.0. It doesn't catch the case we've seen the most in the past, though: using `travel_back` to finish the test will not raise an offense. However, it does detect a useless `travel_back` call in `after` blocks, so I guess it's better than nothing.
This rule was added in rubocop-rails 2.13.0. We were already applying it most of the time.
a95390a
to
c8270d5
Compare
javierm
approved these changes
Aug 24, 2022
taitus
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop-rails from 2.11.3 to 2.15.2.
Release notes
Sourced from rubocop-rails's releases.
... (truncated)
Changelog
Sourced from rubocop-rails's changelog.
... (truncated)
Commits
cc4c272
Cut 2.15.2582ba11
Update Changeloga20671e
Merge pull request #730 from koic/add_new_rails_date_time_range_cop990a786
Merge pull request #736 from rubocop/fix-false-negative-in-rails-delegatea703aaf
[Fix #737] Fix a false positive forRails/DeprecatedActiveModelErrorsMethods
03b4f2f
Add the style guide URL forRails/ExpandedDateRange
15858ae
MakeRails/ExpandedDateRange
awarebeginning_of_week
with an argument3019c2b
[Fix #712] Fixed false negative when visibility modifier is declared in neste...0c18551
Merge pull request #733 from kazarin/fix_incorrect_autocorrect_for_rails_stri...da37010
Merge pull request #734 from rubocop/refactor-correction-specsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)