Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete rake tasks #4999

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Remove obsolete rake tasks #4999

merged 3 commits into from
Oct 4, 2022

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 3, 2022

References

Objectives

  • Remove no longer needed code
  • Make it easier to make rake tasks compatible with multitenancy

@javierm
Remove tasks to upgrade to version 1.5.0
5719f32 
These tasks are not needed for new installations, and in existing
installations they've already been executed when upgrading to version
1.5.0.
@javierm
Remove unused task to send dashboard notifications
e221c3c 
This task was "temporarily" removed in commit 7b66195. Since that was
done three and a half years ago, right after the dashboard was
introduced, I think it's time to make this "temporary" measure a bit
more permanent ;).
@javierm
Remove unused task to reset the vote counters
f15f250 
This task was added in commit 2b9b78e. According to the notes in the
pull request introducing the change:

> If you have had [map validations] in production, you might want to run
> the rake task votes:reset_vote_counter to reset the cached votes
> counter. Otherwise, until there is another vote for a proposal, the
> counter will not be updated, and there might be some votes which are
> not yet displayed

In short, this was a task that was introduced for a specific release and
had to be run manually. So we can remove it now.
@javierm javierm self-assigned this Oct 3, 2022
@javierm javierm added this to Reviewing in Consul Democracy Oct 3, 2022
@taitus taitus self-assigned this Oct 4, 2022
Consul Democracy automation moved this from Reviewing to Testing Oct 4, 2022
@javierm javierm merged commit 28cff52 into master Oct 4, 2022
Consul Democracy automation moved this from Testing to Release 1.6.0 Oct 4, 2022
@javierm javierm deleted the unused_tasks branch October 4, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taitus taitus taitus approved these changes

Assignees

@taitus taitus

@javierm javierm

Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javierm @taitus