Remove duplicate keys in locale files #5084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
reviewed
Feb 21, 2023
taitus
force-pushed
the
check-translations-keys
branch
from
c127228
to
eb4944e
Compare
javierm
reviewed
Feb 22, 2023
In the images.yml file we have a duplicate key with the same translation, so we can remove it. In the admin.yml file we have a duplicate key with different translation. This translation is only used in 2 places in the application: - In the administration table for collaborative legislation proposal index. - In the <% provide :title do %> of the same page. Although it is true that now the second translation (Title) is applied in both cases, I think it makes more sense to use the first one (Proposals) in the page title because it seems to make more sense and be more useful to use "Proposals" instead of “Title”. In order not to modify the behavior in the translation shown in the administration table, we add human_attribute_name to obtain the expected result.
To be consistent with the previous commit we update the text that appears in the administration tables for discussions and proposals. Now instead of "Proposals" and "Discussions" will appear "Title" which makes more sense and is more consistent.
taitus
force-pushed
the
check-translations-keys
branch
from
eb4944e
to
f100e01
Compare
javierm
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Remove duplicated keys in
:enlocales files.